Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ko : added note for get method with body/payload issue #2737

Merged
merged 5 commits into from
Oct 15, 2021
Merged

ko : added note for get method with body/payload issue #2737

merged 5 commits into from
Oct 15, 2021

Conversation

jinwoo1225
Copy link
Contributor

첫 PR입니다. 잘 부탁 드립니다.

  • HTTP GET Method 설명에 누락된 NOTE 추가

궁금한점

  • payload를 무엇으로 번역하는것이 좋을지 궁금합니다.
  • markdown으로 작성을 하려면 어떻게 해야할지 궁금합니다.

@jinwoo1225 jinwoo1225 requested a review from a team as a code owner October 15, 2021 06:14
@jinwoo1225 jinwoo1225 requested review from hochan222 and removed request for a team October 15, 2021 06:14
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Oct 15, 2021
@jinwoo1225 jinwoo1225 changed the title added note for get method with body/payload issue ko : added note for get method with body/payload issue Oct 15, 2021
@jinwoo1225
Copy link
Contributor Author

오픈채팅방에 있었네요. 다음 PR은 이렇게 해보겠습니다.
https://egas.tistory.com/m/52

hochan222
hochan222 requested changes Oct 15, 2021
View reviewed changes
Copy link
Member

@hochan222 hochan222 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jinwoo1225 안녕하세요. 리뷰 드립니다.

markdown에 관련해서는 아직 전환을 위한 몇가지 예외처리를 하지 않아서 yarn run md 명령어로 완벽하게 전환이 안될 수 있지만, 안되는 부분은 en-us 본문을 참고하여 수동으로 전환할 수 있습니다.

세부 리뷰사항은 코드에 커멘트로 남겼습니다.

기여해주셔서 감사합니다. 좋은 하루 보내세요 :)

files/ko/web/http/methods/get/index.html Outdated Show resolved Hide resolved
@jinwoo1225 @hochan222
Update files/ko/web/http/methods/get/index.html
99a044d 
Co-authored-by: hochan Lee <hochan049@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2021 •
edited
Loading

Preview URLs

Flaws

URL: /ko/docs/Web/HTTP/Methods/GET
Title: GET
on GitHub
Flaw count: 2

  • macros:
    • /ko/docs/Glossary/Cacheable does not exist but fallbacked on /en-US/docs/Glossary/cacheable
  • translation_differences:
    • Differences in the important macros (1 in common of 4 possible)

External URLs

URL: /ko/docs/Web/HTTP/Methods/GET
Title: GET
on GitHub

No new external URLs

(this comment was updated 2021-10-15 06:56:10.177912)

@hochan222
Copy link
Member

hochan222 commented Oct 15, 2021 •
edited
Loading

payload를 무엇으로 번역하는것이 좋을지 궁금합니다.

payload의 경우 단어의 사용이, Promise (프로미스)나 Prototype(프로토타입)과 같이 한국어로 번역된 단어보다는 영어 단어 자체로 의미가 굳혀진 단어중 하나입니다. 번역하고자 한다면 페이로드로 변환하면 좋다고 생각합니다.

@jinwoo1225
Copy link
Contributor Author

jinwoo1225 commented Oct 15, 2021 •
edited
Loading

@hochan222 답변 감사드립니다. payload를 국문으로 수정후에 커밋하겠습니다!

@jinwoo1225 jinwoo1225 requested review from a team and schalkneethling and removed request for a team October 15, 2021 06:45
hochan222
hochan222 approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@hochan222 hochan222 merged commit 316e329 into mdn:main Oct 15, 2021
@hochan222 hochan222 removed the request for review from schalkneethling October 15, 2021 06:56
@jinwoo1225 jinwoo1225 deleted the http_get_method branch October 15, 2021 09:43
@hochan222 hochan222 mentioned this pull request Oct 16, 2021
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hochan222 hochan222 hochan222 approved these changes

Assignees
No one assigned
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinwoo1225 @hochan222